Fix mistral for pdf documents - #424
Conversation
eab99c7 to
39bd8d3
Compare
edward-ly
left a comment
There was a problem hiding this comment.
Would you be able to split the refactors and the actual fix into separate commits? That would make things easier to review.
1269c8c to
e0b0249
Compare
Rebased it and split it into two commits. Edit: Due to #431 the refactor isn't needed anymore. |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
e0b0249 to
3b7e484
Compare
edward-ly
left a comment
There was a problem hiding this comment.
Haven't tested this myself yet as I don't have a Mistral account, but the code looks fine regardless 🚀
For future reference you can actually create a free account. Mistral has a free tier for testing. |
|
Hi @lukasdotcom can we get this backported to v24? It looks like this app's minimum app version is 35 |
Hi @cbcoutinho, This can't be backported as the fix is only for multimodal chat which only exists in the main branch not any of the stable branches. |
Also had an llm refactor the isUsing functions into openAiSettingsService so there weren't circular dependencies.Thanks @cbcoutinho for finding this issue originally.🤖 AI (if applicable)