Skip to content

Fix mistral for pdf documents - #424

Merged
lukasdotcom merged 1 commit into
mainfrom
fix-mistral
Sep 16, 2026
Merged

lukasdotcom merged 1 commit into
mainfrom
fix-mistral

Conversation

@lukasdotcom

@lukasdotcom lukasdotcom commented Aug 7, 2026

Copy link
Copy Markdown
Member

Also had an llm refactor the isUsing functions into openAiSettingsService so there weren't circular dependencies. Thanks @cbcoutinho for finding this issue originally.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@edward-ly edward-ly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to split the refactors and the actual fix into separate commits? That would make things easier to review.

@lukasdotcom
lukasdotcom force-pushed the fix-mistral branch 2 times, most recently from 1269c8c to e0b0249 Compare September 14, 2026 19:18
@lukasdotcom

lukasdotcom commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Would you be able to split the refactors and the actual fix into separate commits? That would make things easier to review.

Rebased it and split it into two commits.

Edit: Due to #431 the refactor isn't needed anymore.

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>

@edward-ly edward-ly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this myself yet as I don't have a Mistral account, but the code looks fine regardless 🚀

@lukasdotcom

Copy link
Copy Markdown
Member Author

Haven't tested this myself yet as I don't have a Mistral account, but the code looks fine regardless 🚀

For future reference you can actually create a free account. Mistral has a free tier for testing.

@lukasdotcom
lukasdotcom merged commit c461a56 into main Sep 16, 2026
25 checks passed
@lukasdotcom
lukasdotcom deleted the fix-mistral branch September 16, 2026 13:38
@cbcoutinho

Copy link
Copy Markdown

Hi @lukasdotcom can we get this backported to v24? It looks like this app's minimum app version is 35

@lukasdotcom

Copy link
Copy Markdown
Member Author

Hi @lukasdotcom can we get this backported to v24? It looks like this app's minimum app version is 35

Hi @cbcoutinho,

This can't be backported as the fix is only for multimodal chat which only exists in the main branch not any of the stable branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants