Skip to content

Add imip processing in the background#6812

Merged
ChristophWurst merged 1 commit into
mainfrom
enh/process-imip-in-background
Sep 9, 2022
Merged

Add imip processing in the background#6812
ChristophWurst merged 1 commit into
mainfrom
enh/process-imip-in-background

Conversation

@miaulalala

@miaulalala miaulalala commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Fixes #6802

Questions:

what happens when I have a very large mailbox where I never trigger the preview for messages below the fold?

@miaulalala miaulalala added enhancement 2. developing feature:imip For all tasks related to the iMIP functionality labels Jun 30, 2022
@miaulalala miaulalala self-assigned this Jun 30, 2022
Comment thread lib/Db/Message.php Outdated
Comment thread lib/Db/Message.php Outdated
Comment thread lib/Db/MessageMapper.php Outdated
Comment thread lib/Migration/Version1140Date20220630113356.php Outdated
Comment thread lib/Migration/Version1140Date20220630113356.php Outdated
Comment thread lib/Migration/Version1140Date20220630113356.php Outdated
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from b43b7fe to f113610 Compare July 19, 2022 12:01
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 1bfa02a to 649689e Compare July 29, 2022 14:18
@miaulalala

This comment was marked as off-topic.

@kevincox

This comment was marked as off-topic.

@miaulalala

This comment was marked as off-topic.

@kevincox

This comment was marked as off-topic.

@miaulalala

This comment was marked as off-topic.

@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 649689e to fa7ec4e Compare August 11, 2022 10:44
@miaulalala
miaulalala marked this pull request as ready for review August 11, 2022 12:14
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from fa7ec4e to 768221d Compare August 11, 2022 12:24
@miaulalala

miaulalala commented Aug 11, 2022

Copy link
Copy Markdown
Contributor Author
  • add another BG job that processes all messages until 2 weeks into the past for structure Analysis. (should make mail app faster)

Comment thread lib/Service/IMipService.php

@kesselb kesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to bump the version number to install the background job.

Comment thread tests/Unit/Service/PreprocessingServiceTest.php Outdated
Comment thread lib/Db/MessageMapper.php Outdated
Comment thread lib/IMAP/MessageMapper.php
Comment thread lib/IMAP/MessageMapper.php
Comment thread lib/Service/IMipService.php Outdated
Comment thread lib/Db/MessageMapper.php Outdated
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from bc259c4 to 62463a8 Compare August 17, 2022 11:09
Comment thread lib/Service/IMipService.php Outdated
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 62463a8 to 33842a8 Compare August 18, 2022 09:26
@miaulalala

miaulalala commented Aug 22, 2022

Copy link
Copy Markdown
Contributor Author

just waiting for server PR now

@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 49ed373 to cc930ce Compare August 22, 2022 20:14
@miaulalala

miaulalala commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

stable22, 23 and 24 test failing is not surprising as this isn't backported

@ChristophWurst ChristophWurst added this to the v2.0.0 milestone Sep 6, 2022
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from cc930ce to 30b183f Compare September 7, 2022 22:53
@miaulalala

Copy link
Copy Markdown
Contributor Author

@ChristophWurst I added a check on the IManager to see if the method handleImipReply exists so we can avoid the whole test suite exploding for the next however many releases.

Shamelessly stolen from https://github.com/nextcloud/calendar/blob/main/tests/php/unit/Service/Appointments/BookingServiceTest.php

@ChristophWurst ChristophWurst mentioned this pull request Sep 8, 2022
6 tasks
Comment thread lib/BackgroundJob/PreviewEnhancementProcessingJob.php Outdated
Comment thread lib/Db/MessageMapper.php Outdated
Comment thread lib/Migration/Version1140Date20220630113356.php Outdated
Comment thread lib/Service/MailManager.php Outdated
Comment thread lib/Service/PreprocessingService.php Outdated
Comment thread lib/Service/PreprocessingService.php Outdated
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 30b183f to 673fdf3 Compare September 8, 2022 13:18
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch 2 times, most recently from e2197b8 to 35cf81a Compare September 8, 2022 13:42
@ChristophWurst

Copy link
Copy Markdown
Member

linter

@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from dca353a to 2a72eca Compare September 8, 2022 15:43
Comment thread lib/BackgroundJob/IMipMessageJob.php Outdated
Comment thread lib/BackgroundJob/IMipMessageJob.php Outdated
@miaulalala
miaulalala force-pushed the enh/process-imip-in-background branch from 8f5db2f to 0dcfb5f Compare September 9, 2022 10:59
Signed-off-by: Anna Larch <anna@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement feature:imip For all tasks related to the iMIP functionality

Projects

Development

Successfully merging this pull request may close these issues.

Process iMip responses

4 participants