Send browser notifications again#372
Merged
nickvergessen merged 1 commit intoJul 9, 2019
Merged
Conversation
Since the transition-group was added the parent was not the NotificationsList anymore therefor backgroundFetch was always undefined and we never sent out HTML notifications Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
/backport to stable16 |
rullzer
approved these changes
Jul 9, 2019
delete-merged-branch
Bot
deleted the
bugfix/noid/send-browser-notifications-again
branch
July 9, 2019 11:05
|
The backport to stable16 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the transition-group was added the parent was not the NotificationsList anymore
therefor backgroundFetch was always undefined and we never sent out HTML notifications
Regression from #300