Skip to content

fix(Application.php): Update methods post-refactor - #3380

Merged
juliusknorr merged 1 commit into
mainfrom
fix/issue3363
Dec 27, 2023
Merged

fix(Application.php): Update methods post-refactor#3380
juliusknorr merged 1 commit into
mainfrom
fix/issue3363

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

Summary

The refactor in #3315 swapped around a few methods and this updates Application.php to use the appropriate ones.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Fixes #3363. The refactor in #3315 swapped around a few methods and this updates Application.php to use the appropriate ones.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

@manuelkamp manuelkamp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solved the issue

@juliusknorr

Copy link
Copy Markdown
Member

Thanks @joshtrichards

I'm puzzled why psalm has not thrown an error for this case, but that is not a blocker for getting this in of course.

@juliusknorr
juliusknorr merged commit b6de97a into main Dec 27, 2023
@juliusknorr
juliusknorr deleted the fix/issue3363 branch December 27, 2023 14:40
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable28

@gehkah

gehkah commented Jan 9, 2024

Copy link
Copy Markdown

The fix works for eliminating the errors. But It now hangs on uploading large files, like ISOs onto Nextcloud. Some instances crash. others just dont finalize the upload. I got NC instances where I did not apply this fix, there its working. on 3 instances, where I applied this fix, I got this problem. waiting on a new release.

@joshtrichards

Copy link
Copy Markdown
Member Author

@gehkah Please open a bug report so that we can get the info needed to solve that. I'm afraid a mere comment on the original PR isn't sufficient to reproduce + fix the problem you're reporting (if it is, indeed, even related)

@gehkah

gehkah commented Jan 12, 2024

Copy link
Copy Markdown

@gehkah Please open a bug report so that we can get the info needed to solve that. I'm afraid a mere comment on the original PR isn't sufficient to reproduce + fix the problem you're reporting (if it is, indeed, even related)

Dear Josh

I'm sorry for the circumstances. I upgraded to php8.3 and the problems are gone on my instances. I applied your fix to other NC instances and reproduces the problem unter php8.2 (VM, debian bullseye, apache2) but when I upgraded these to php 8.3, the problem no longer exists. No more 100% cpu usage or vm crash, I'm able to upload ISOs again. I'm fine with it. thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

4 participants