Cache extractFields response from Collabora - #3916
Merged
Merged
Conversation
elzody
added
3. to review
elzody
force-pushed
the
feat/cache-template-response
branch
from
August 15, 2024 18:31
0d9e360 to
6036628
Compare
elzody
marked this pull request as ready for review
August 15, 2024 18:32
juliusknorr
approved these changes
Aug 16, 2024
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Just one small issue with checking the cache, otherwise 馃憤
elzody
force-pushed
the
feat/cache-template-response
branch
from
August 19, 2024 20:39
54652a0 to
beee109
Compare
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
force-pushed
the
feat/cache-template-response
branch
from
August 19, 2024 20:50
beee109 to
04024fc
Compare
Collaborator
Author
|
/backport to stable30 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I rebased this PR onto #3885 because it includes a fix for an error due to using
getFirstNodeById()incorrectly.Thus, should probably wait for #3885 to be merged before merging this one
The response from extracting fields via the Collabora endpoint should be cached as long as the file has not changed, since it prevents an extra hit to Collabora. When the file changes then, it should re-hit the Collabora endpoint for the updated template fields, then cache from there.
Checklist