[Bug]: Icon "More" in header should use the primary text colour

[danxuliu]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Icon More in header is using icon-more-white, so its colour depends on whether the light or dark mode is used. However, as it appears with a transparent background on the header, which uses the primary colour and does not change based on whether dark mode is used or not, the icon colour should be set to var(--primary-color-text) instead (well, I guess so :-) ).

Steps to reproduce

Scenario 1:

• If not set already, set the default colour in the Theming app
• Enable dark mode
• Narrow the window until the More icon is shown in the list of apps in the header

Scenario 2:

• If not set already, set the default colour in the Theming app
• Enable dark mode (in the browser)
• Share a file with a public link
• Open the link

Expected behavior

The icon should be "white", but it is "black" instead.

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

Default apps from a fresh Git installation + Talk.

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[szaimen]

@danxuliu is this still happening?

[skjnldsv]

Yep it is. It's bound to the same issue about the background image colour from #34665

[Pytal]

Fixed icon on light background in #34714

Scenario 1 with default color and background already fixed in https://github.com/nextcloud/server/pull/33728/files#diff-c0e4c093ed80a9daa2dbfd0136eeea47ac257eead156c4243f9de1b61042c368R238

Scenario 2 already fixed in https://github.com/nextcloud/server/pull/34028/files#diff-c43c0216867d11378193d94f4c233f97980af311e569572cf1cdc8d06b3f377d