[BITV] App navigation sidebar a11y

[PVince81]

Foreach of these:

• add role='navigation' on the item with id="app-navigation"
• the selected item needs to have aria-current="page" set for the currently selected item (the one which already has class="active")

Grep result:

• apps/files/templates/appnavigation.php|1 col 6| <div id="app-navigation">: Add a11y attributes for legacy app navigation #33746
• apps/settings/templates/settings/frame.php|32 col 6| <div id="app-navigation">: Add a11y attributes for legacy app navigation #33746
• apps/settings/templates/help.php|4 col 6| <div id="app-navigation">: Add a11y attributes for legacy app navigation #33746
• apps/activity/templates/stream.app.navigation.php|25 col 6| <div id="app-navigation">: Add role=navigation and aria-current activity#899

[PVince81]

Regarding preventing tabbing, I did an experiment using the inert attribute and it would successfully prevent tabbing there

however the main problem is the snap.js library that doesn't properly fire events on closing, dragging, etc.
so either we find the right way to hack around it or we switch to a better library.

snap.js was already a huge problem due to animation event leaking in the past: #23785

[PVince81]

potential alternatives:

• https://github.com/SidebarJS/sidebarjs

[PVince81]

ok, actually the new Vue sidebar already supports swiping: #32488 (comment)