Show reason why group restriction not possible for that app

[MorrisJobke]

Papercut from #2672

cc @eppfel @MariusBluem because you always asked for this

[wiswedel]

@MorrisJobke Is this still of interest or can it be closed? Can't there be several reasons - none of them giving the reader any practical benefit?

[MorrisJobke]

Can't there be several reasons - none of them giving the reader any practical benefit?

Yes there can be different and it would be helpful to communicate why given features are not there IMO.

[szaimen]

I am going to close this since there doesn't seem to be a lot of interest (no upvotes) and no respond since around 2 years. Please reopen if you still want to implement this.

[joshtrichards]

I suppose these are the reasons:

server/apps/settings/src/mixins/AppManagement.js

Lines 74 to 82 in 7ddad46

	canLimitToGroups(app) {
	if ((app.types && app.types.includes('filesystem'))
	|| app.types.includes('prelogin')
	|| app.types.includes('authentication')
	|| app.types.includes('logging')
	|| app.types.includes('prevent_group_restriction')) {
	return false
	}
	return true

server/apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue

Line 15 in 7ddad46

<div v-if="app.active && canLimitToGroups(app)" class="app-details__actions-groups">

server/lib/private/App/AppManager.php

Lines 35 to 44 in 7ddad46

	* Apps with these types can not be enabled for certain groups only
	* @var string[]
	*/
	protected $protectedAppTypes = [
	'filesystem',
	'prelogin',
	'authentication',
	'logging',
	'prevent_group_restriction',
	];

Apps this applies to:

https://github.com/search?q=org%3Anextcloud+path%3A%2F%28%5E%7C%5C%2F%29info%5C.xml%24%2F+filesystem+OR+prelogin+OR+authentication+OR+logging+OR+prevent_group_restrictions&type=code

For many (most?) of these it's somewhat obvious why they can't be limited. But I can see how a few might be surprising (e.g. Collectives, Photos, Maps, Community Document Server, Office Online, Activity).