add LDAP integr. test for receiving share candidates with group limitation#15858
Merged
Conversation
blizzz
force-pushed
the
enh/noid/ldap-sharee-limited-groups
branch
7 times, most recently
from
June 7, 2019 11:01
d3aba6f to
e4bb5ed
Compare
blizzz
force-pushed
the
enh/noid/ldap-sharee-limited-groups
branch
2 times, most recently
from
June 13, 2019 14:50
44516d7 to
6517f4c
Compare
blizzz
added
3. to review
blizzz
requested review from
ChristophWurst,
danxuliu,
icewind1991,
juliusknorr and
skjnldsv
June 13, 2019 16:29
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
skjnldsv
approved these changes
Jun 13, 2019
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Code looks good! Let's see tests :)
Member
Author
test case was added to |
…ation Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
there is not such strange return mode. Having invalid user ids caused this check to fail, and as side effect share limitation to groups to not work. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
skjnldsv
force-pushed
the
enh/noid/ldap-sharee-limited-groups
branch
from
June 14, 2019 04:24
6517f4c to
1d48c03
Compare
Member
|
Rebased to trigger drone EDIT: passed https://drone.nextcloud.com/nextcloud/server/19244/60/5 |
ChristophWurst
approved these changes
Jun 14, 2019
blizzz
added
4. to release
|
backport to stable16 in #15984 |
|
backport to stable15 in #15985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.