Skip to content

Set timeout for http requests to 10min#17807

Closed
kesselb wants to merge 1 commit into
masterfrom
bug/17776/higher-http-timeout
Closed

Set timeout for http requests to 10min#17807
kesselb wants to merge 1 commit into
masterfrom
bug/17776/higher-http-timeout

Conversation

@kesselb

@kesselb kesselb commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Fix #17776
Fix #17792
Fix #17808

I fear there will be more reports if we keep such a low value. Probably a config value make sense here.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@rullzer

rullzer commented Nov 4, 2019

Copy link
Copy Markdown
Member

600 seconds will probbaly timeout in the webserver....

@kesselb

kesselb commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

Probably ;) What do you suggest?

@TP75

TP75 commented Nov 5, 2019

Copy link
Copy Markdown

600 seconds will probbaly timeout in the webserver....

#17808 promotes 120 seconds, way to go until 5 Minutes but well above 30 seconds, I presume

and was already reported before as #17685

@nickvergessen

Copy link
Copy Markdown
Member

30 seconds is a reasonable default. If we require a longer timeout on some requests, we should specify them on those requests individually

@kesselb kesselb deleted the bug/17776/higher-http-timeout branch November 25, 2019 11:27
@rEnr3n

rEnr3n commented Nov 25, 2019

Copy link
Copy Markdown

It's also going to depend on internet speeds. People with fast connections will find 30 seconds to be reasonable. Not so much for those with slower connections.

@nickvergessen

Copy link
Copy Markdown
Member

No, this value here only affects your nextcloud connecting with other nextclouds, the appstore, .... Not the user-to-nextcloud connection

@rEnr3n

rEnr3n commented Nov 25, 2019

Copy link
Copy Markdown

Yes. The issue is common with appstore. This particular app is big, 16MB currently. https://github.com/nextcloud/weather/releases

@nickvergessen

Copy link
Copy Markdown
Member

If we require a longer timeout on some requests, we should specify them on those requests individually

@TP75

TP75 commented Nov 25, 2019

Copy link
Copy Markdown

@nickvergessen

No, this value here only affects your nextcloud connecting with other nextclouds, the appstore, .... Not the user-to-nextcloud connection

Sorry but currently I do not quite understand your approach. IMHO this issue was closed by due reason and same argument.

New issue opened as #18103 for addressing more options and for defining a technical solution more acceptable to admins. Or would this be misleading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve the timeout value for CURL error Curl 28 nextcloud 17 curl command - timedout

5 participants