Only save login credentials in database once there is an external storage that needs it

[icewind1991]

Also fixes #6343

[kesselb]

This patch also helps with #6343 as the data is not written anymore on login.

How do you detect changed credentials without listening to postLogin?

[icewind1991]

How do you detect changed credentials without listening to postLogin?

Forgot about that 🙈 , will need to add something for that

[icewind1991]

How do you detect changed credentials without listening to postLogin?

Forgot about that see_no_evil , will need to add something for that

done

[kesselb]

done

Nice 👍 Much cleaner than before and will still help with #6343 as the password is only updated on change 🚀

[kesselb]

@rullzer @MorrisJobke @juliushaertl 🏓

[MorrisJobke]

Let me fix this :)

[MorrisJobke]

Tested and works 👍

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31206: failure

mysql8.0-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyDirectory
Failed asserting that false is true.

/drone/src/tests/lib/Files/Storage/Storage.php:550

integration-external-storage

Could not fetch logs