Skip to content

Principal search by display name case insensitive#31886

Merged
PVince81 merged 1 commit into
masterfrom
bugfix/noid/principal-search-case-insensitive-dn
Apr 14, 2022
Merged

Principal search by display name case insensitive#31886
PVince81 merged 1 commit into
masterfrom
bugfix/noid/principal-search-case-insensitive-dn

Conversation

@PVince81

@PVince81 PVince81 commented Apr 8, 2022

Copy link
Copy Markdown
Member

Adjust principal search to be case insensitive even with exact match.
This aligns the behavior to how the search also works in
Collaborators/UserPlugin

This aligns the behavior with https://github.com/nextcloud/server/blob/bugfix/noid/principal-search-case-insensitive-dn/lib/private/Collaboration/Collaborators/UserPlugin.php#L180

To test:

  1. Disable share autocomplete to trigger exact match mode
  2. Create an event
  3. Type in the exact display name of a user, but with different casing

Before the fix: no results
After the fix: one result found

Adjust principal search to be case insensitive even with exact match.
This aligns the behavior to how the search also works in
Collaborators/UserPlugin

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 self-assigned this Apr 8, 2022
@PVince81 PVince81 added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Apr 8, 2022
@PVince81 PVince81 added this to the Nextcloud 24 milestone Apr 8, 2022
@miaulalala

Copy link
Copy Markdown
Contributor

Nice, this also brings us more into line with RFC3774;

The actual search method (exact matching vs. substring matching vs,
prefix-matching, case-sensitivity) deliberately is left to the server
implementation to allow implementation on a wide set of possible user
management systems. In cases where the implementation of
DAV:principal-property-search is not constrained by the semantics of
an underlying user management repository, preferred default semantics
are caseless substring matches.

@PVince81

PVince81 commented Apr 8, 2022

Copy link
Copy Markdown
Member Author

/backport to stable23

@PVince81

PVince81 commented Apr 8, 2022

Copy link
Copy Markdown
Member Author

/backport to stable22

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2022
@blizzz blizzz mentioned this pull request Apr 13, 2022
@PVince81 PVince81 merged commit 0824f44 into master Apr 14, 2022
@PVince81 PVince81 deleted the bugfix/noid/principal-search-case-insensitive-dn branch April 14, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: caldav Related to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants