Skip to content

ci(checkers): Fix autoloader (re)generation for extraneous apps #37476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Apr 14, 2023
+5 −0
Merged

ci(checkers): Fix autoloader (re)generation for extraneous apps #37476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build/autoloaderchecker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ echo "Regenerating main autoloader"
$COMPOSER_COMMAND dump-autoload -d $REPODIR

for app in ${REPODIR}/apps/*; do
if git check-ignore ${app} -q ; then

@go2sh go2sh Apr 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be the other way arround? git check-ignore returns 0 if the file is ignored. This will only non ignored files will be skipped like this.

@ChristophWurst ChristophWurst Apr 13, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if git check-ignore apps/mail -q ; then echo "mail should be skipped"; fi -> goes into the conditional branch. This is what we want here. If the file is ignored we want to continue the loop.

echo
echo "${app} is not shipped. Ignoring autoloader regeneration"
continue
fi
if [[ -d $app ]]; then
if [[ -e ${app}/composer/composer.json ]]; then
echo
Expand Down