Skip to content

Split list to navigation for the left sidebar#40576

Merged
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36915-_The_page_only_has_one_h1_heading
Sep 29, 2023
Merged

Split list to navigation for the left sidebar#40576
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36915-_The_page_only_has_one_h1_heading

Conversation

@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor

⚠️⚠️⚠️ could be a breaking change (but we are far behind NC25) #36915 (comment)

Summary

Before After
Screenshot from 2023-09-22 10-25-09 Screenshot from 2023-09-22 10-24-59

Checklist

Comment thread apps/settings/templates/settings/frame.php
Comment thread apps/settings/templates/settings/frame.php
@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor Author

@artonge do you have any breaking changes in mind?

@artonge

artonge commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

@artonge do you have any breaking changes in mind?

No

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36915-_The_page_only_has_one_h1_heading branch from 35df25a to 7e633ff Compare September 25, 2023 15:07
@Pytal

Pytal commented Sep 28, 2023

Copy link
Copy Markdown
Member

Drone looks related ;)

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36915-_The_page_only_has_one_h1_heading branch from 7e633ff to 5693092 Compare September 28, 2023 16:19
Comment thread core/css/apps.scss
Comment on lines +142 to +143
.app-navigation-caption,
.app-navigation-caption {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.app-navigation-caption,
.app-navigation-caption {
.app-navigation-caption {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BITV] 9.1.3.1a/7.1 - The page only has one "h1" heading. Neither the left-side navigation nor the main content is structured by the headings. (1)

5 participants