Skip to content

Remove disputed bz2 check#42821

Merged
come-nc merged 1 commit into
nextcloud:masterfrom
J0WI:rm-bz2-check
Jan 22, 2024
Merged

Remove disputed bz2 check#42821
come-nc merged 1 commit into
nextcloud:masterfrom
J0WI:rm-bz2-check

Conversation

@J0WI

@J0WI J0WI commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

Summary

This is fixing kind of a regression of #40889 by restoring the previous behavior. The regression and reason is described in #42342.

TODO

Checklist

@J0WI

J0WI commented Jan 15, 2024

Copy link
Copy Markdown
Contributor Author

/backport to stable28

@J0WI

J0WI commented Jan 15, 2024

Copy link
Copy Markdown
Contributor Author

/rebase

Signed-off-by: J0WI <J0WI@users.noreply.github.com>

@joshtrichards joshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per my comments on docs PR + the related issue in server

@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Jan 19, 2024
@J0WI J0WI added this to the Nextcloud 28.0.2 milestone Jan 19, 2024
@J0WI J0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2024
This was referenced Jan 22, 2024
@blizzz blizzz modified the milestones: Nextcloud 28.0.2, Nextcloud 29 Jan 22, 2024
@blizzz

blizzz commented Jan 22, 2024

Copy link
Copy Markdown
Member

master is 29, fixed the milestone

@come-nc

come-nc commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

/backport to stable28

@come-nc come-nc merged commit d515227 into nextcloud:master Jan 22, 2024
@J0WI J0WI deleted the rm-bz2-check branch January 23, 2024 23:52
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification: Is bz2 still really recommended PHP module?

5 participants