fix(Storage): Document getOwner() can return false#48094
Merged
Conversation
provokateurin
requested review from
a team,
Altahrim,
come-nc and
yemkareems
and removed request for
a team
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
Will do! |
Contributor
Was merged, got you a few conflicts. |
provokateurin
force-pushed
the
fix/storage/get-owner-false
branch
from
74ad1fd to
c99fdf9
Compare
Member
Author
|
Failure probably related :/ |
provokateurin
force-pushed
the
fix/storage/get-owner-false
branch
from
c99fdf9 to
7091b80
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/storage/get-owner-false
branch
from
7091b80 to
dc13f9c
Compare
skjnldsv
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
2 tasks
This was referenced Sep 18, 2024
Merged
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The return type of getOwner() was never specified, but all implementations already treat it as
string|false.Checklist