fix(activity): make emails for link share uploads true by default#49688
Merged
Conversation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
Altahrim and
icewind1991
and removed request for
a team
8 tasks
Member
Author
|
/backport to stable30 |
sorbaugh
approved these changes
Dec 6, 2024
provokateurin
approved these changes
Dec 6, 2024
Member
No, that basically overwrites ALL users custom settings to the programmatic default. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #49133
Setting is new by default since Nc 30
BTW, Wouldn't it make sense to reset the
'activity', 'configured'user config, so that we can set defaults again?https://github.com/nextcloud/activity/blob/4044007b25aae32ae423f85b9d2f51c8c8cf780e/lib/Listener/SetUserDefaults.php