Skip to content

feat(occ): Better handling of disabled or unreacheable App store#49697

Merged
Altahrim merged 1 commit into
masterfrom
appStoreDisabledOcc
Jun 11, 2026
Merged

feat(occ): Better handling of disabled or unreacheable App store#49697
Altahrim merged 1 commit into
masterfrom
appStoreDisabledOcc

Conversation

@solracsf

@solracsf solracsf commented Dec 6, 2024

Copy link
Copy Markdown
Member

Summary

Set either appstoreenabled or has_internet_connection to false on config.php file.

Previously in all cases:

# occ app:update previewgenerator
previewgenerator is up-to-date or no updates could be found

After:

# occ app:update previewgenerator
App store access is disabled

or

# occ app:update previewgenerator
Internet connection is disabled, and therefore the default public App store is not reachable

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Dec 6, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Dec 6, 2024
@solracsf solracsf force-pushed the appStoreDisabledOcc branch from 24a5bfc to bcc9d07 Compare December 16, 2024 14:24
@solracsf solracsf requested review from a team, ArtificialOwl, come-nc, icewind1991, provokateurin and yemkareems and removed request for a team December 16, 2024 14:25
@solracsf solracsf changed the title feat(occ): Better handling of disabled appstore message feat(occ): Better handling of disabled or unreacheable App store Dec 16, 2024
@solracsf solracsf enabled auto-merge December 16, 2024 14:27

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add two tests for this?

@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Jan 9, 2026
This was referenced Jan 20, 2026
This was referenced Jan 29, 2026
This was referenced Feb 11, 2026
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@DorraJaouad DorraJaouad requested a review from a team as a code owner April 23, 2026 09:41
@DorraJaouad DorraJaouad requested review from CarlSchwan and artonge and removed request for a team and yemkareems April 23, 2026 09:41
This was referenced Jun 5, 2026
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@Altahrim Altahrim force-pushed the appStoreDisabledOcc branch from bcc9d07 to 600178d Compare June 11, 2026 08:09
@Altahrim Altahrim disabled auto-merge June 11, 2026 09:36
@Altahrim Altahrim merged commit 7269f43 into master Jun 11, 2026
155 of 171 checks passed
@Altahrim Altahrim deleted the appStoreDisabledOcc branch June 11, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants