fix: Ensure label is always a string#50447
Merged
Merged
Conversation
susnux
requested review from
a team,
artonge,
provokateurin and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
AndyScherzinger
approved these changes
Jan 26, 2025
Contributor
Author
Yes because every share provider needed to be patched... Would be easier if we have strong typings for parameters... |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/share-label
branch
from
46ed78a to
305e1bb
Compare
This was referenced Jan 26, 2025
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure a string is set also for the mail provider and validate valid length of it.
Checklist