[stable30] fix: Create download attribute when toggling checkbox#52516
Merged
nfebe merged 2 commits intoMay 16, 2025
Conversation
nfebe
requested review from
ArtificialOwl,
artonge,
skjnldsv,
susnux and
szaimen
nfebe
changed the title
download attribute when toggling checkbo…download attribute when toggling checkbo…
nfebe
changed the title
download attribute when toggling checkbo…download attribute when toggling checkbox
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
nfebe
force-pushed
the
fix/stable30/create-download-attribute-if-missing
branch
from
c0ff359 to
300c216
Compare
nfebe
force-pushed
the
fix/stable30/create-download-attribute-if-missing
branch
from
300c216 to
250c072
Compare
Contributor
Author
|
/compile |
artonge
approved these changes
May 12, 2025
…x if missing Previously, toggling the checkbox did not create the 'download' attribute if it was missing, causing it to become unresponsive after a page reload. Now, setShareAttribute ensures the attribute is updated or created correctly. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/stable30/create-download-attribute-if-missing
branch
from
e4ddf65 to
6558dc9
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, toggling the checkbox did not create the 'download' attribute if it was missing, causing it to become unresponsive after a page reload. Now, setShareAttribute ensures the attribute is updated or created correctly.
Also a partial backport of : #50739