fix(caldav): url-encode owner/user in activity event links#61973
fix(caldav): url-encode owner/user in activity event links#61973Otto-Deviant1904 wants to merge 1 commit into
Conversation
Activity links break when a uid has a space, since owner/affectedUser weren't url-encoded the way calendar_uri already is. Wrapped both in rawurlencode(), same fix joshtrichards okayed on the issue. Added two test cases for uids with spaces and confirmed they fail without the fix. Fixes #61738 Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: OttoDev <f20240223@goa.bits-pilani.ac.in>
65f100b to
2da2c93
Compare
|
Thank you for the PR |
|
Thank you for the PR. This is the correct fix. I will need to recreate the PR tho as our CI will not pass on a fork. |
|
Closing in favour of #62063 As CI will not pass on a fork |
|
Sure works with me |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Fixes #61738.
Activity links break when a uid has a space, since owner/affectedUser weren't url-encoded the way calendar_uri already is. Wrapped both in rawurlencode(), same fix @joshtrichards okayed on the issue.
Added two test cases for uids with spaces and confirmed they fail without the fix, pass with it. Ran the full EventTest suite locally (13 tests, 55 assertions, all passing).
Assisted with Claude Code.