fix: Revert to registering autoloading app by app while booting them - #64000
Open
come-nc wants to merge 1 commit into
Open
fix: Revert to registering autoloading app by app while booting them#64000come-nc wants to merge 1 commit into
come-nc wants to merge 1 commit into
Conversation
It appears that this change had a bad perf impact. My theory is that some app autoloaders are slow and with the previous change they were used for a larger part of the boot process. Autoloader performance should be investigated (and there is ongoing work) but for now let’s revert to the faster version. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim,
icewind1991,
salmart-dev and
sorbaugh
September 3, 2026 12:52
Contributor
Author
|
/backport to stable35 |
provokateurin
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial revert of #63388
It appears that this change had a bad perf impact. My theory is that
some app autoloaders are slow and with the previous change they were
used for a larger part of the boot process. Autoloader performance
should be investigated (and there is ongoing work) but for now let’s
revert to the faster version.
Checklist
3. to review, feature component)stable32)AI (if applicable)