Skip to content

fix(db): copy referenced tables first in db:convert-type - #66377

Open
szaimen wants to merge 1 commit into
masterfrom
fix/db-convert-type-fk-order
Open

szaimen wants to merge 1 commit into
masterfrom
fix/db-convert-type-fk-order

Conversation

@szaimen

@szaimen szaimen commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The tables were copied in arbitrary order while the foreign keys already exist in the target database, so the conversion failed with a foreign key violation as soon as a table referenced a table that is copied later on (e.g. oc_mail_accounts and oc_mail_mailboxes).

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The tables were copied in arbitrary order while the foreign keys already
exist in the target database, so the conversion failed with a foreign
key violation as soon as a table referenced a table that is copied
later on (e.g. oc_mail_accounts and oc_mail_mailboxes).

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen added this to the Nextcloud 36 milestone Nov 5, 2026
@szaimen
szaimen requested a review from a team as a code owner November 5, 2026 16:33
@szaimen szaimen added the bug label Nov 5, 2026
@szaimen
szaimen requested review from leftybournes and removed request for a team November 5, 2026 16:33
@szaimen szaimen added the 3. to review Waiting for reviews label Nov 5, 2026
@szaimen
szaimen requested a review from provokateurin November 5, 2026 16:33
@szaimen

szaimen commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35 please

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go with this community PR? #64642

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration from snap not working

3 participants