Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
nextcloud
/
server
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
5.2k
Star
36.8k
Code
Issues
2.7k
Pull requests
982
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Wiki
Security and quality
Insights
Add confirmation button to share input
- #7196
#7196
Merged
MorrisJobke
merged 17 commits into
master
nextcloud/server:master
from
sharing-confirm-button
nextcloud/server:sharing-confirm-button
Copy head branch name to clipboard
Mar 21, 2018
Conversation
Commits
17
(17)
Checks
Files changed
Merged
Add confirmation button to share input
#7196
MorrisJobke
merged 17 commits into
master
nextcloud/server:master
from
sharing-confirm-button
nextcloud/server:sharing-confirm-button
Copy head branch name to clipboard
Commits
Commits on Mar 20, 2018
Replace information icon with confirmation button in share input
Show description for ce7775a
jancborchardt
authored and
danxuliu
committed
ce7775a
View commit details
Copy full SHA for ce7775a
Browse repository at this point
Adjust search term to test
Show description for 6fef01c
danxuliu
committed
6fef01c
View commit details
Copy full SHA for 6fef01c
Browse repository at this point
Add tests for emails and circles already shared with
Show description for 375eab9
danxuliu
committed
375eab9
View commit details
Copy full SHA for 375eab9
Browse repository at this point
Add tests for exact search results already shared with
Show description for 8af9c55
danxuliu
committed
8af9c55
View commit details
Copy full SHA for 8af9c55
Browse repository at this point
Add autocompletion tests for each type of share
Show description for 3980364
danxuliu
committed
3980364
View commit details
Copy full SHA for 3980364
Browse repository at this point
Extract code to get suggestions to its own method
Show description for d606219
danxuliu
committed
d606219
View commit details
Copy full SHA for d606219
Browse repository at this point
Move stub setup outside the test method
Show description for fcef15a
danxuliu
committed
fcef15a
View commit details
Copy full SHA for fcef15a
Browse repository at this point
Use "showTemporary" instead of explicitly hiding the notification
Show description for ed1452d
danxuliu
committed
ed1452d
View commit details
Copy full SHA for ed1452d
Browse repository at this point
Show an error when getting the suggestions succeeds with failure content
Show description for 1c44051
danxuliu
committed
1c44051
View commit details
Copy full SHA for 1c44051
Browse repository at this point
Extract code to filter suggestions to its own function
Show description for 89b0e34
danxuliu
committed
89b0e34
View commit details
Copy full SHA for 89b0e34
Browse repository at this point
Return also exact matches besides all suggestions
Show description for 5e2a8cc
danxuliu
committed
5e2a8cc
View commit details
Copy full SHA for 5e2a8cc
Browse repository at this point
Add a share when clicking on the confirm button
Show description for 9371b61
danxuliu
committed
9371b61
View commit details
Copy full SHA for 9371b61
Browse repository at this point
Confirm a share also by pressing enter on the input field
Show description for 10a4f8e
danxuliu
committed
10a4f8e
View commit details
Copy full SHA for 10a4f8e
Browse repository at this point
Commits on Mar 21, 2018
Reuse last suggestions if the same parameters are used
Show description for 6eb5cc5
danxuliu
committed
6eb5cc5
View commit details
Copy full SHA for 6eb5cc5
Browse repository at this point
Discard cached suggestions when adding a share
Show description for 9a0fbe3
danxuliu
committed
9a0fbe3
View commit details
Copy full SHA for 9a0fbe3
Browse repository at this point
Extract code to restore the UI after confirming a share
Show description for a2c52cd
danxuliu
committed
a2c52cd
View commit details
Copy full SHA for a2c52cd
Browse repository at this point
Keep showing the working icon while there are pending operations
Show description for 203bf51
danxuliu
committed
203bf51
View commit details
Copy full SHA for 203bf51
Browse repository at this point
You can’t perform that action at this time.