Skip to content

fix: Do not update page title for single file public shares#2789

Merged
skjnldsv merged 3 commits into
masterfrom
fix/single-share-title
Apr 4, 2025
Merged

fix: Do not update page title for single file public shares#2789
skjnldsv merged 3 commits into
masterfrom
fix/single-share-title

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Apr 1, 2025

Copy link
Copy Markdown
Member

The filename is empty and is already set on page load

To reproduce share a single file as a public share link, open it.

Page title before: "Readme.md - Nextcloud"

Page title after: "- Nextcloud"

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Apr 1, 2025

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! FYI @skjnldsv this happens when opening odt documents e.g. on daily and the title shows as "- Nextcloud Daily" without the file name before.

@juliusknorr juliusknorr added this to the Nextcloud 32 milestone Apr 1, 2025
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Apr 1, 2025

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@skjnldsv

skjnldsv commented Apr 4, 2025

Copy link
Copy Markdown
Member

/compile rebase

juliusknorr and others added 2 commits April 4, 2025 01:20
The filename is empty and is alerady set on page load

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 9a9a016 into master Apr 4, 2025
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Apr 4, 2025
@skjnldsv skjnldsv deleted the fix/single-share-title branch April 4, 2025 01:31
@skjnldsv

This comment was marked as resolved.

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Apr 4, 2025
@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv

skjnldsv commented Apr 4, 2025

Copy link
Copy Markdown
Member

/backport 92862fb to stable31

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Apr 4, 2025
@skjnldsv

skjnldsv commented Apr 4, 2025

Copy link
Copy Markdown
Member

/backport 92862fb to stable30

@backportbot

backportbot Bot commented Apr 4, 2025

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/2789/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 92862fb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2789/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2789/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv

skjnldsv commented Apr 4, 2025

Copy link
Copy Markdown
Member

/backport 92862fb to stable29

@backportbot

backportbot Bot commented Apr 4, 2025

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2789/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 92862fb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2789/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2789/stable30."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Apr 4, 2025

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2789/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 92862fb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2789/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2789/stable29."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr juliusknorr removed the backport-request Pending backport by the backport-bot label Jun 4, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
susnux pushed a commit that referenced this pull request May 16, 2026
fix: Do not update page title for single file public shares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants