Skip to content

Fix three dead links in the docs - #538

Merged
Kevin-Brockers merged 1 commit into
nf-core:devfrom
karpovantonme:fix/dead-doc-links-dev
Aug 21, 2026
Merged

Fix three dead links in the docs#538
Kevin-Brockers merged 1 commit into
nf-core:devfrom
karpovantonme:fix/dead-doc-links-dev

Conversation

@karpovantonme

Copy link
Copy Markdown

PR checklist

  • This comment contains a description of changes (with reason)
  • Documentation only, no code or tests touched
  • Made sure the PR targets dev

Description

Three links in docs/output.md return 404.

Link Where it moved
bioinf.wehi.edu.au/featureCounts/ subread.sourceforge.net/featureCounts.html
github.com/macs3-project/MACS/blob/master/docs/callpeak.md#output-files macs3-project.github.io/MACS/docs/callpeak.html, the file is gone from the repository
cran.r-project.org/web/packages/UpSetR/README.html cran.r-project.org/package=UpSetR, CRAN dropped that layout

The featureCounts one is already fixed in README.md on dev, so this brings docs/output.md in line with it.

All three old URLs return 404 right now and all three new ones return 200.

How this was found

Pulled every external link out of the markdown files, 304 unique URLs, and requested each one with a browser user agent. Counted only 404, 410 and 451, leaving out 403 and timeouts since those can be my network rather than a dead page.

After this change one 404 remains, github.com/sofiahaglund in the credits list. I left it alone deliberately: it is a person's account in a thank-you list, and removing someone from credits is not my call.

The featureCounts link is dead across the org

The same dead URL appears 22 times in 11 nf-core repositories: atacseq, callingcards, chipseq, magmap, metatdenovo, modules, nanoseq, nascent, panoramaseq, rnaseq, rnasplice.

modules matters most, since that one propagates outward. Happy to send the same one-line fix to the others, or to modules alone if you would rather handle the propagation your own way. Say which and I will do it.

- featureCounts moved from bioinf.wehi.edu.au to subread.sourceforge.net.
  The README link was already updated on dev, docs/output.md still had the
  old one
- MACS callpeak docs are now on macs3-project.github.io, the file no longer
  exists in the repository
- CRAN dropped the web/packages/<name>/README.html layout, cran.r-project.org/package=UpSetR is the stable form

All three old URLs return 404 and all three new ones return 200.
@github-actions

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 4.0.3.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the Synchronisation documentation.

@Kevin-Brockers Kevin-Brockers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @karpovantonme, thanks a lot for your contribution and for fixing the dead links!

@github-actions

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 491839e

+| ✅ 271 tests passed       |+
#| ❔   5 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   8 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config
  • files_unchanged - File ignored due to lint config: assets/nf-core-chipseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-chipseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.3
  • Run at 2026-08-21 06:42:30

@Kevin-Brockers
Kevin-Brockers merged commit 2923ac3 into nf-core:dev Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants