Replace removed cgi module and update SRA_IDS_TO_RUNINFO to Python 3.13.7 - #403
Open
Flobo2689x wants to merge 3 commits into
Open
Flobo2689x wants to merge 3 commits into
Flobo2689x wants to merge 3 commits into
Conversation
cgi was removed in Python 3.13, so the script failed with "ModuleNotFoundError: No module named 'cgi'" when run outside the pinned Python 3.9 conda environment or container. Read the charset from the response headers with get_content_charset() instead.
Bump the conda environment and the container of SRA_IDS_TO_RUNINFO from Python 3.9 to 3.13.7, and update the module and pipeline snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
Description
bin/sra_ids_to_runinfo.py: the charset is now read withself._response.headers.get_content_charset("utf-8")instead ofcgi.parse_header().cgiwas removed in Python 3.13.get_content_charset()is available on all supported Python versions.SRA_IDS_TO_RUNINFO: conda environment and containers bumped from Python 3.9 to 3.13.7 (conda-forge::python=3.13.7,biocontainers/python:3.13.7,https://depot.galaxyproject.org/singularity/python:3.13.7).SRA_IDS_TO_RUNINFOpython version changes.MULTIQC_MAPPINGS_CONFIGandSRA_RUNINFO_TO_FTPstill pin Python 3.9.5. I left them out to keep this PR focused on the issue. I can bump them in a follow-up if you want.Testing
nf-test test modules/local/sra_ids_to_runinfo/tests/main.nf.test --profile +docker: 3/3 passed. TheSRR13191702.runinfo.tsvmd5 is unchanged; only the version entry differs.nf-test test workflows/tests/sra_skip_fastq_download.nf.test --profile +docker: passed.nf-core pipelines lint: 0 failed. The 5 warnings are all TODO strings or a missing subworkflow meta.yml, none of them related to this change.No module named 'cgi', the patched one gives the same output as on 3.9.PR checklist
nf-core pipelines lint).sra_skip_fastq_download, not the full suite.CHANGELOG.mdis updated.