Repository navigation
Fix validationErrors type - #361
Merged
Merged
Conversation
Contributor
|
Thank you for bringing this to our attention. There are actually a few typing errors like this. I'll review this and see if this fix by itself is sufficient. |
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 9 9
Lines 856 856
Branches 227 227
=======================================
Hits 618 618
Misses 137 137
Partials 101 101
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cjbarth
approved these changes
Jul 22, 2023
cjbarth
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the examples it is shown that the value can be read. Therefore, the value should not be marked as private.