Use http-proxy-middleware for CORS proxy#527
Merged
Merged
Conversation
By delegating all proxy functionality to an existing library, we avoid the need for extra tests and checks on our side.
RubenVerborgh
force-pushed
the
feature/proxy-handler
branch
from
b0ffa60 to
9736334
Compare
RubenVerborgh
force-pushed
the
feature/proxy-handler
branch
from
da7e706 to
495c6df
Compare
dmitrizagidulin
approved these changes
Aug 8, 2017
dmitrizagidulin
left a comment
dmitrizagidulin
left a comment
Contributor
There was a problem hiding this comment.
Excellent, I'm glad http-proxy-middleware fits our needs! Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes error codes and messages.