lookup: remove q - #1123
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Have their been concrete problems the maintainers have been unresponsive to? Nothing short of that can violate the hard requirements imo. |
|
q should be removed from citgm. q is not compatible with Node.js 26. It cannot be built and fails testing. The repo is archived meaning that no new issues can be opened and no further development is planned. Steps to reproduceUbuntu 24.04.4 LTS, Node.js 24.7.0 git clone https://github.com/kriskowal/q
cd q
npm installLogs$ npm install
npm warn deprecated graceful-fs@1.2.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm warn deprecated rimraf@2.2.8: Rimraf versions prior to v4 are no longer supported
npm warn deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm warn deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm warn deprecated mkdirp@0.3.0: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated mkdirp@0.3.5: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated glob@3.1.21: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated electron@0.2.1: The original electron project has been moved. Visit github.com/logicalparadox/electron for more details.
npm warn deprecated glob@3.2.1: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated glob@3.2.11: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated coffee-script@1.3.3: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
npm warn deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm warn deprecated jasmine-node@1.11.0: jasmine-node 1.x & 2.x are deprecated, with known vulnerability in jasmine-growl-reporter pre-2.0.0
npm warn deprecated mocha@1.11.0: Mocha v1.x is no longer supported.
npm warn deprecated sinon@1.7.3: 16.1.1
npm warn deprecated buster-core@0.6.4: No longer maintained
> q@1.5.1 prepublish
> grunt
Loading "uglify.js" tasks...ERROR
>> Error: Cannot find module '_stream_transform'
>> Require stack:
>> - /home/mike/github/PACKAGES/q/node_modules/browserify-zlib/src/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/gzip-size/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/maxmin/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt-contrib-uglify/tasks/uglify.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt/lib/grunt/task.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt/lib/grunt.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt-cli/bin/grunt
Warning: Task "uglify" not found. Use --force to continue.
Aborted due to warnings.
npm error code 3
npm error path /home/mike/github/PACKAGES/q
npm error command failed
npm error command sh -c grunt |
@kriskowal would be welcome to respond here, however since the package is deprecated and the repo is archived, that is a clear message that there will be no response to issues, including to the incompatibility with Node.js 26. |
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
+1 from me on the basis of the archived state. Tagging the former maintainer as a courtesy in case of any objections to the premise that it is unsupported is a reasonable course of action. I presume there is nothing that has superceded it?
On a related note, we should perhaps consider doing another cycle of #959 since the current process for @nodejs/releasers (who i'm tagging for awareness/input since there are a few of these removal PRs from Mike) is typically "compare with the last version and make sure it's no worse" which I'd suggest is not ideal although generally works.
The deprecation notice says:
so I believe there wouldn't be any specific replacement needed in citgm. It would be JavaScript Promise MDN instead and this is used in Node.js code in multiple places, so it is already intrinsically tested. |
4 participants
JSONStream,leveldown&qetc. #1113Situation
q is deprecated and unsupported. It cannot therefore fulfil the Hard Requirements:
npm Author message:
Change
Remove q from lib/lookup.json
Checklist
npm testpasseshere
cc: @kriskowal