- Node Version: Unrelated
- Platform: All
- Compiler: Unrelated
- Module: Any
This PR --> #1670 removes support for obsolete io.js versions, this is perfectly valid however because of the way that logic was originally implemented, over on the Electron team for our 1.x/2.x/3.x releases, we had to publish our headers with the iojs prefix instead of the node prefix.
As of node-gyp@5.0 these versions no longer work and currently we still support Electron 3 so ideally this would be fixed. I've raised a simple "revent the PR that broke it" PR, if that's acceptable it would be great to merge and release that, otherwise I can craft a PR to specifically introduce support back for these headers.
Revert PR: #1777
Refs: electron/electron#18787
This PR --> #1670 removes support for obsolete io.js versions, this is perfectly valid however because of the way that logic was originally implemented, over on the Electron team for our 1.x/2.x/3.x releases, we had to publish our headers with the
iojsprefix instead of thenodeprefix.As of
node-gyp@5.0these versions no longer work and currently we still support Electron 3 so ideally this would be fixed. I've raised a simple "revent the PR that broke it" PR, if that's acceptable it would be great to merge and release that, otherwise I can craft a PR to specifically introduce support back for these headers.Revert PR: #1777
Refs: electron/electron#18787