Skip to content

test: if-error-has-good-stack is broken on windows #18377

@joyeecheung

Description

@joyeecheung

https://ci.nodejs.org/job/node-test-binary-windows/14484/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=2/console

match failed
line=4
expect=^\ \ \ \ at\ z\ \(.*\/if\-error\-has\-good\-stack\.js\:.*\:.*$
actual=    at z (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:19:14)
not ok 497 message/if-error-has-good-stack
  ---
  duration_ms: 0.212
  severity: fail
  stack: |-
    assert.js:499
        throw newErr;
        ^
    
    AssertionError [ERR_ASSERTION]: ifError got unwanted exception: test error
        at z (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:19:14)
        at y (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:20:7)
        at x (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:21:5)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:22:3)
        at c (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:11:13)
        at b (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:12:7)
        at a (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:13:5)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:14:3)
        at Module._compile (module.js:661:30)
        at Object.Module._extensions..js (module.js:672:10)
        at Module.load (module.js:578:32)
        at tryModuleLoad (module.js:518:12)
        at Function.Module._load (module.js:510:3)
        at Function.Module.runMain (module.js:702:10)

There is a / in the filename which cannot be matched on Windows

cc @BridgeAR

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions