Investigate flaky test-child-process-exit-code

[Trott]

https://ci.nodejs.org/job/node-test-commit-linux-containered/9393/nodes=ubuntu1604_sharedlibs_debug_x64/consoleText

test-digitalocean-ubuntu1604_sharedlibs_container-x64-7

not ok 267 parallel/test-child-process-exit-code
  ---
  duration_ms: 1.127
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:86
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    null !== 23
    
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-child-process-exit-code.js:31:10)
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:335:15)
        at ChildProcess.emit (events.js:189:13)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
  ...

[Trott]

Now on AIX:

https://ci.nodejs.org/job/node-test-commit-aix/19721/nodes=aix61-ppc64/consoleText

test-osuosl-aix61-ppc64_be-2

not ok 219 parallel/test-child-process-exit-code
  ---
  duration_ms: 7.799
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:86
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    null !== 23
    
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-child-process-exit-code.js:31:10)
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:335:15)
        at ChildProcess.emit (events.js:189:13)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
  ...

[gireeshpunathil]

'assert.js:86
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

null !== 23

    at ChildProcess.<anonymous> (test/parallel/test-child-process-exit-code.js:31:10)
    at ChildProcess.<anonymous> (test/common/index.js:335:15)
    at ChildProcess.emit (events.js:189:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)

(gdb) where
#0  0x000000080323d277 in pthread_mutex_destroy () from /lib/libthr.so.3
#1  0x000000080323c7e6 in pthread_mutex_lock () from /lib/libthr.so.3
#2  0x000000000145b86d in v8::platform::tracing::TracingController::GetCategoryGroupEnabledInternal ()
#3  0x0000000000e60316 in v8::internal::CancelableLambdaTask<v8::internal::ArrayBufferCollector::FreeAllocations()::$_0>::RunInternal ()
#4  0x0000000000980fb6 in node::(anonymous namespace)::PlatformWorkerThread ()
#5  0x0000000803235c06 in pthread_create () from /lib/libthr.so.3
#6  0x0000000000000000 in ?? ()
(gdb) thr 2
[Switching to thread 2 (process 100447)]#0  0x0000000803516fe3 in realloc () from /lib/libc.so.7
(gdb) where
#0  0x0000000803516fe3 in realloc () from /lib/libc.so.7
#1  0x00000008035175b1 in free () from /lib/libc.so.7
#2  0x00000000008fdf38 in std::__1::__tree<s...>::destroy ()
#3  0x00000000008fdf1d in std::__1::__tree<s...>::destroy ()
#4  0x00000000008fdf29 in std::__1::__tree<s...>::destroy ()
#5  0x00000000008fdf1d in std::__1::__tree<s...>::destroy ()
#6  0x00000000008fdf1d in std::__1::__tree<s...>::destroy ()
#7  0x00000000008fdf1d in std::__1::__tree<s...>::destroy ()
#8  0x00000000008fdf29 in std::__1::__tree<s...>::destroy ()
#9  0x0000000803591911 in __cxa_finalize () from /lib/libc.so.7
#10 0x000000080351f001 in exit () from /lib/libc.so.7
#11 0x00000000008d9231 in node::Environment::Exit ()
#12 0x00000000008f986e in node::Exit ()
#13 0x0000000000b2a148 in v8::internal::FunctionCallbackArguments::Call ()
#14 0x0000000000b2974d in v8::internal::(anonymous namespace)::HandleApiCallHelper<false> ()
#15 0x0000000000b28f17 in v8::internal::Builtin_Impl_HandleApiCall ()
#16 0x000000000171218e in Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit ()
#17 0x000007024d40816e in ?? ()
...
(gdb)

Again, the usual suspects. linking #25007 and #25061

[gireeshpunathil]

the test is active for the last one week with no failures, so as expected #25061 has fixed the underlying issue. Closing.