worker.exitedAfterDisconnect is false, after the worker process has exited using process.exit()

[nimit95]

Version: 10.16.0
Platform: 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64

Call process.exit() in worker/child, in master log the value after any worker exit

[sam-github]

https://nodejs.org/api/cluster.html#cluster_worker_exitedafterdisconnect

Set by calling .kill() or .disconnect(). Until then, it is undefined.

The behaviour you describe is exactly what is documented. Neither kill() or disconnect() was called in your situation, the worker called exit(), so exitedAfterDisconnect is false.

[nimit95]

But shouldn't it be undefined as documented. .kill() or .disconnect() has not been called

[nimit95]

Should we fix it at the documentation level or fix the code?
I can make PR for any of the above two case

[sam-github]

It's repeatedly normalized from truthy/falsy to true/false: worker.exitedAfterDisconnect = !!worker.exitedAfterDisconnect. I'm not sure about the history of this. Can you troll the git history to see why this occurs?

I strongly suspect current behaviour is an improvement, but the docs need updating.

Also, I wonder, is the initial value false? If not, it probably should be.

[nimit95]

Okay I will see what I can find and get back

[nimit95]

Yeah I checked out the git history to this PR #3743
Here .suicide was replaced by .exitedAfterDisconnect but the truthy/falsy to true/false was retained and documentation was updated too but not anything about false. truth/false seems suicide behaviour.

Yeah, it was an improvement over .suicide
IMO docs and the code both need an update, it should be true or false, and the change reflected in the docs. If you approve I can create a PR for the fix of this.

[sam-github]

@nimit95 Please PR a fix, thanks.