Skip to content

fs: WritableStream issues #29042

@ronag

Description

@ronag
  • error can be emitted after close
    • write after end
    • invalid argument
  • open can be emitted after error
  • does not use errorOrDestroy on close()
  • should not emit error, use errorOrDestroy or callback.
  • _write does an unnecessary check for instanceof Buffer (fs: unecessary argument validation #29043).
  • calling write before fd and closing, will cause write to happen on destroyed stream (i.e. flush after destroy)
  • don't use end() instead of destroy(). Keep track of pendingcb instead. (related issue stream: Writable should not invoke _destroy while pending ops #29044)
  • emit 'close' on destroy
  • emit 'close' close error

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions