-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
src: fix performance regression in node_file.cc #31340
Copy link
Copy link
Closed
Labels
lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.
Metadata
Metadata
Assignees
Labels
lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in
InternalModuleReadJSON()into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.cc @guybedford @jkrems