Skip to content

stream: 'prefinish' timing and 'finish' after 'close' #31401

@ronag

Description

@ronag
  • 'finish' can be emitted after 'close' if destroy() is called inside a'prefinish' handler.
  • 'prefinish' has different timing (sync vs async) depending on whether Writable implements _final which can cause problems such as above to occur or not occur. (stream: simplify Transform stream implementation #32763)

I assume 'prefinish' is mostly used internally so it's probably not a huge issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    streamIssues and PRs related to the stream subsystem.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions