cctest BaseObjectPtrTest failing on master

[devsnek]

• commit dd4c62e
• linux 5.4.15-arch1-1

[----------] 6 tests from BaseObjectPtrTest
[ RUN      ] BaseObjectPtrTest.ScopedDetached
../test/cctest/test_base_object_ptr.cc:50: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 1
  0
../test/cctest/test_base_object_ptr.cc:53: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:55: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 1
  0
[  FAILED  ] BaseObjectPtrTest.ScopedDetached (31 ms)
[ RUN      ] BaseObjectPtrTest.ScopedDetachedWithWeak
../test/cctest/test_base_object_ptr.cc:66: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 1
  0
../test/cctest/test_base_object_ptr.cc:70: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:73: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 1
  0
[  FAILED  ] BaseObjectPtrTest.ScopedDetachedWithWeak (18 ms)
[ RUN      ] BaseObjectPtrTest.Undetached
../test/cctest/test_base_object_ptr.cc:87: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:83: Failure
Expected equality of these values:
  static_cast<Environment*>(arg)->base_object_count()
    Which is: 1
  0
[  FAILED  ] BaseObjectPtrTest.Undetached (18 ms)
[ RUN      ] BaseObjectPtrTest.GCWeak
../test/cctest/test_base_object_ptr.cc:104: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:111: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
[  FAILED  ] BaseObjectPtrTest.GCWeak (20 ms)
[ RUN      ] BaseObjectPtrTest.Moveable
../test/cctest/test_base_object_ptr.cc:129: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:140: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 2
  1
../test/cctest/test_base_object_ptr.cc:145: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 1
  0
[  FAILED  ] BaseObjectPtrTest.Moveable (32 ms)
[ RUN      ] BaseObjectPtrTest.NestedClasses
../test/cctest/test_base_object_ptr.cc:175: Failure
Expected equality of these values:
  env->base_object_count()
    Which is: 4
  3
../test/cctest/test_base_object_ptr.cc:167: Failure
Expected equality of these values:
  static_cast<Environment*>(arg)->base_object_count()
    Which is: 1
  0
[  FAILED  ] BaseObjectPtrTest.NestedClasses (18 ms)
[----------] 6 tests from BaseObjectPtrTest (137 ms total)

[richardlau]

Do you have a link to a failing CI job (either our CI or Travis CI) or is this only failing locally for you? If so are you using any configure options?

Also this looks like what you reported in #31321 (comment) so can you double check it's not a leftover from that PR?

[devsnek]

@richardlau only locally as far as I can tell. This is after ./configure with no options and make clean.

[addaleax]

@devsnek If you want to debug this, you may be able to iterate over the list of BaseObjects using the same mechanism that Environment::ForEachBaseObject uses in a debugger? Is there anything unusual about the way you run cctests, e.g. with specific env vars that affect Node? Otherwise I think this is pretty hard to debug if it’s only failing for you locally… :/

[devsnek]

@addaleax aha yeah i have NODE_OPTIONS set and it's loading a script, deleting the var first results in tests passing...

[addaleax]

@devsnek Thanks, that makes sense :) We should probably unset that env var for the entire cctest…