I just noticed some very minor things while idly browsing recent node commits. /cc @benjamingr.
Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. The commit above introduced it as a getter.
Note that url.js appears to do this correctly using the defineIDLClass function, which perhaps should be shared.
isTrusted should not have a setter. It should only have a getter, since it is declared as a readonly Web IDL attribute.
I just noticed some very minor things while idly browsing recent node commits. /cc @benjamingr.
Per Web IDL,
EventTarget.prototype[Symbol.toStringTag]should be a data property, not a getter. The commit above introduced it as a getter.Note that url.js appears to do this correctly using the
defineIDLClassfunction, which perhaps should be shared.isTrustedshould not have a setter. It should only have a getter, since it is declared as areadonlyWeb IDL attribute.