parallel/test-http-header-overflow starts flaking

[joyeecheung]

Test

parallel/test-http-header-overflow

Platform

win2012r2-COMPILED_BY-vs2019-x86

Console output

13:11:08 not ok 314 parallel/test-http-header-overflow
13:11:08   ---
13:11:08   duration_ms: 0.306
13:11:08   severity: fail
13:11:08   exitcode: 1
13:11:08   stack: |-
13:11:08     node:assert:635
13:11:08           throw err;
13:11:08           ^
13:11:08     
13:11:08     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
13:11:08     + actual - expected ... Lines skipped
13:11:08     
13:11:08       Comparison {
13:11:08     +   bytesParsed: 10642,
13:11:08     -   bytesParsed: 16402,
13:11:08         code: 'HPE_HEADER_OVERFLOW',
13:11:08         message: 'Parse Error: Header overflow',
13:11:08         name: 'Error',
13:11:08     +   rawPacket: Buffer(10645) [Uint8Array] [
13:11:08     ...
13:11:08     -   rawPacket: Buffer(16405) [Uint8Array] [
13:11:08     -     71,
13:11:08     -     69,
13:11:08     -     84,
13:11:08     -     32,
13:11:08     -     47,
13:11:08     -     98,
13:11:08     -     108,
13:11:08     -     97,
13:11:08     -     104,
13:11:08     -     32,
13:11:08     -     72,
13:11:08     -     84,
13:11:08     -     84,
13:11:08     -     80,
13:11:08     -     47,
13:11:08     -     49,
13:11:08     -     46,
13:11:08     -     49,
13:11:08     -     13,
13:11:08     -     10,
13:11:08     -     67,
13:11:08     -     111,
13:11:08     -     111,
13:11:08     -     107,
13:11:08     -     105,
13:11:08     -     101,
13:11:08     -     58,
13:11:08     -     32,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     -     97,
13:11:08     ...
13:11:08         at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:618:12)
13:11:08         at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:411:15)
13:11:08         at Socket.emit (node:events:539:35)
13:11:08         at emitErrorNT (node:internal/streams/destroy:164:8)
13:11:08         at emitErrorCloseNT (node:internal/streams/destroy:129:3)
13:11:08         at processTicksAndRejections (node:internal/process/task_queues:82:21) {
13:11:08       generatedMessage: true,
13:11:08       code: 'ERR_ASSERTION',
13:11:08       actual: [Error: Parse Error: Header overflow] {
13:11:08         bytesParsed: 10642,
13:11:08         code: 'HPE_HEADER_OVERFLOW',
13:11:08         reason: 'Header overflow',
13:11:08         rawPacket: Buffer(10645) [Uint8Array] [
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97, 97,
13:11:08           97, 97, 97, 97,
13:11:08           ... 10545 more items
13:11:08         ]
13:11:08       },
13:11:08       expected: {
13:11:08         name: 'Error',
13:11:08         message: 'Parse Error: Header overflow',
13:11:08         code: 'HPE_HEADER_OVERFLOW',
13:11:08         bytesParsed: 16402,
13:11:08         rawPacket: Buffer(16405) [Uint8Array] [
13:11:08            71,  69, 84, 32, 47, 98, 108, 97, 104,  32,  72,  84,
13:11:08            84,  80, 47, 49, 46, 49,  13, 10,  67, 111, 111, 107,
13:11:08           105, 101, 58, 32, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97, 97, 97,  97, 97,  97,  97,  97,  97,
13:11:08            97,  97, 97, 97,
13:11:08           ... 16305 more items
13:11:08         ]
13:11:08       },
13:11:08       operator: 'throws'
13:11:08     }
13:11:08     
13:11:08     Node.js v18.0.0-pre
13:11:08   ...

Build links

• (Likely the first one, for buffer: improve Blob constructor error message when passing a string #42338) https://ci.nodejs.org/job/node-test-binary-windows-js-suites/14084/RUN_SUBSET=3,nodes=win2012r2-COMPILED_BY-vs2019-x86/
• https://ci.nodejs.org/job/node-test-binary-windows-js-suites/14102/RUN_SUBSET=3,nodes=win2012r2-COMPILED_BY-vs2019-x86/

(Both on test-rackspace-win2012r2_vs2013-x64-1)

Additional information

No response

[lpinca]

The actual rawPacket does not begin with 'GET /blah HTTP/1.1\r\nCookie: ' so I guess the data is not received as a single chunk. I wonder if eacd456 has anything to do with this.

[lpinca]

I'm not able to reproduce the issue in my Windows 10 machine.

[shnooshnoo]

Had a quick look into this test and found no traces of this currently failing.
According to reliability reports last time it failed in may 2022.
Also, it's been failing on win2012 which is no longer supported.
With this in mind, looks like this issue can be closed now?

[lpinca]

I'm closing this. Thank you @shnooshnoo.