misc/startup benchmark broken as of 3c4ee52

[mscdex]

Version

master

Platform

n/a

Subsystem

benchmark

What steps will reproduce the bug?

Run the misc/startup benchmark.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

------ stdout ------

------ stderr ------
node:internal/modules/cjs/loader:808
      throw new ERR_UNKNOWN_BUILTIN_MODULE(filename);
      ^

Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: test
    at new NodeError (node:internal/errors:372:5)
    at Function.Module._load (node:internal/modules/cjs/loader:808:13)
    at Module.require (node:internal/modules/cjs/loader:1006:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/bench/node/benchmark/fixtures/require-cachable.js:9:3)
    at Module._compile (node:internal/modules/cjs/loader:1106:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1160:10)
    at Module.load (node:internal/modules/cjs/loader:982:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  code: 'ERR_UNKNOWN_BUILTIN_MODULE'
}

Node.js v18.0.0-pre

/home/bench/node/benchmark/misc/startup.js:49
      throw new Error(`Error during node startup, exit code ${code}`);
      ^

Error: Error during node startup, exit code 1
    at ChildProcess.<anonymous> (/home/bench/node/benchmark/misc/startup.js:49:13)
    at ChildProcess.emit (node:events:527:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)

Node.js v18.0.0-pre

Additional information

/cc @cjihrig

[mscdex]

It's also interesting that this wasn't picked up by CI.....

[Trott]

It's also interesting that this wasn't picked up by CI.....

The first configuration runs successfully and the tests only run one configuration for each benchmark so that's why it passed:

misc/startup.js
misc/startup.js mode="process" script="benchmark/fixtures/require-builtins" dur=0.05: 14.094491103317608

The tests can't check every possible configuration, of course, so they are just a minimal smoke-test that catches completely broken benchmarks.