Add self-assignment cases in SocketAddress

[wooffie]

Version

20.18.0

Platform

any

Subsystem

src

What steps will reproduce the bug?

I think we can add check for self-assigment in ctors/assigment operators

node/src/node_sockaddr-inl.h

Line 87 in 309924f

memcpy(&address_, &addr.address_, addr.length());

Expect to see this:

SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
  if (this != &addr) {
    memcpy(&address_, &addr.address_, addr.length());
  }
  return *this;
}

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Maybe not calling memcpy

What do you see instead?

Calling memcpy

Additional information

I wanna hear your opinion about this =)

[jazelly]

I think it would be an enhancement. Feel free to raise a PR. That way this will get more attention.