tests: test-debugger-util-regression failure "program should not terminate"

[jhamhader]

• Version: latest (commit fb5f66a)
• Platform: Linux 4.4.5-1-ARCH x86_64 GNU/Linux
• Subsystem: tests

Running make test (regardless of the number of jobs) produces the following failure:

=== release test-debugger-util-regression ===
Path: parallel/test-debugger-util-regression
assert.js:90
  throw new assert.AssertionError({
  ^
AssertionError: the program should not terminate
    at Object.exports.fail (/home/<username>/src/node/test/common.js:462:10)
    at Socket.proc.stdout.on (/home/<username>/src/node/test/parallel/test-debugger-util-regression.js:49:12)
    at emitOne (events.js:90:13)
    at Socket.emit (events.js:182:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Socket.Readable.push (_stream_readable.js:111:10)
    at Pipe.onread (net.js:529:20)
Command: out/Release/node /home/<username>/src/node/test/parallel/test-debugger-util-regression.js

and somtimes:

=== release test-debugger-repeat-last ===                                      
Path: parallel/test-debugger-repeat-last
events.js:154
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:893:11)
    at Pipe.onread (net.js:550:26)
Command: out/Release/node /home/<username>/src/node/test/parallel/test-debugger-repeat-last.js

Seems like commit 1df84f4 introduces the issue.

[Fishrock123]

CI for confirmation: https://ci.nodejs.org/job/node-test-commit/2916/

Edit: Looks like this is on Arch linux, which we don't test at the current time.

[Trott]

@thealphanerd Any idea if this is a false positive? Or have we really re-introduced the bug that you wrote this test to find?

[mhdawson]

I am getting an error on my local ubuntu machine as well:

/usr/bin/python tools/test.py --mode=release message parallel sequential -J
=== release test-debugger-util-regression ===
Path: parallel/test-debugger-util-regression
assert.js:90
  throw new assert.AssertionError({
  ^
AssertionError: the program should not hang
    at Object.exports.fail (/home/mhdawson/pulls/ras/io.js/test/common.js:462:10)
    at Timeout.fail [as _onTimeout] (/home/mhdawson/pulls/ras/io.js/test/parallel/test-debugger-util-regression.js:23:10)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
Command: out/Release/node /home/mhdawson/pulls/ras/io.js/test/parallel/test-debugger-util-regression.js

Checkout commit before the debugger change and it runs ok, Checkout 1df84f4 and error occurs.

Machine info:

mhdawson@duv-aurora:~/pulls/ras/io.js$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04.2 LTS
Release:        14.04
Codename:       trusty

[Trott]

The problem is that there are two debugger tests now and they both use the default port for debugging. So when run in parallel (which is what make test does), one of them fails. When run sequentially (as they are on CI, for example), they succeed. I have a PR open to move them to sequential which should fix this issue. #6205 I think this warrants expedited landing (especially given the low stakes nature of the change--just moving them to sequential is really straightforward). If someone wants to parallelize them later by introducing a custom debug port (common.PORT or otherwise), then great. But for now, a few LGTMs on that PR would be awesome.

[Trott]

Fixed on master with 00b2219