[x] fs: don't emit open after destroy#28765
Closed
ronag wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
fs
ronag
force-pushed
the
fix-fs-open-destroy
branch
from
d3fdc9b to
ff9b6fc
Compare
mscdex
reviewed
Jul 19, 2019
ronag
force-pushed
the
fix-fs-open-destroy
branch
2 times, most recently
from
f404a6a to
e7a8e22
Compare
Member
Author
|
This might need a sem-ver major due to the updated test. |
ronag
force-pushed
the
fix-fs-open-destroy
branch
from
e7a8e22 to
281772e
Compare
Member
|
@nodejs/fs |
jasnell
added
the
semver-major
jasnell
approved these changes
Jul 29, 2019
Member
Author
|
@Trott author ready? |
Member
It's semver-major and all (or at least many) semver-major PRs are blocked on standard-things/esm#821. 😞 |
Collaborator
Member
Author
|
Alternative solution which is further into the future nxtedition#2. |
Member
Author
|
closing for now, there are other PR's that solves this better, but with bigger changes. |
ronag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not perfect but still better than it was.
Refs: #23133
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes