src: allow preventing InitializeInspector in env#35025
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
EnvironmentFlagsoption:kNoInitializeInspector.8c5ad13 made it such that
env->InitializeInspectorwas called inCreateEnvironmentno matter what, which creates an issue for embedders seeking to manage the InspectorAgent themselves as Electron does. This new flag mitigates that issue by allowing embedders to prevent that invocation.
cc @joyeecheung
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes