Skip to content

src: allow preventing InitializeInspector in env#35025

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
codebytere:inspector-env-flag
Feb 23, 2022
Merged

src: allow preventing InitializeInspector in env#35025
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
codebytere:inspector-env-flag

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Sep 2, 2020

This PR adds a new EnvironmentFlags option: kNoInitializeInspector.

8c5ad13 made it such that env->InitializeInspector was called in CreateEnvironment
no matter what, which creates an issue for embedders seeking to manage the InspectorAgent themselves as Electron does. This new flag mitigates that issue by allowing embedders to prevent that invocation.

cc @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants