Skip to content

tools: fix create-or-update-pull-request-action hash on GHA#43378

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:fix-gha-pr-opener
Jun 11, 2022
Merged

tools: fix create-or-update-pull-request-action hash on GHA#43378
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
aduh95:fix-gha-pr-opener

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jun 11, 2022

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 11, 2022

Review requested:

  • @nodejs/actions

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 11, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2022

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit c470386 into nodejs:master Jun 11, 2022
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 11, 2022

Landed in c470386

danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@aduh95 @danielleadams
tools: fix create-or-update-pull-request-action hash on GHA
56e56e8 
PR-URL: #43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
italojs pushed a commit to italojs/node that referenced this pull request Jun 12, 2022
@aduh95 @italojs
tools: fix create-or-update-pull-request-action hash on GHA
76e4b67 
PR-URL: nodejs#43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@aduh95 @danielleadams
tools: fix create-or-update-pull-request-action hash on GHA
5b371e0 
PR-URL: #43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@aduh95 @danielleadams
tools: fix create-or-update-pull-request-action hash on GHA
b69d874 
PR-URL: #43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
tools: fix create-or-update-pull-request-action hash on GHA
0806849 
PR-URL: #43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
tools: fix create-or-update-pull-request-action hash on GHA
2ceb19d 
PR-URL: #43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
tools: fix create-or-update-pull-request-action hash on GHA
4688330 
PR-URL: nodejs/node#43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
FelixTJDietrich added a commit to ls1intum/Hephaestus that referenced this pull request May 15, 2026
@FelixTJDietrich @claude
fix(mentor): wave 27 — loop-3 audit fixes
88860e3 
Third audit loop. Three P0s the prior loops missed:

P0-1 — Drift-detection test was itself tautological. It constructed MentorAgentProperties
manually with the literal "pi-mentor-runner.mjs" and asserted that string equalled the
constant. The @DefaultValue was never bound; renaming it would not have failed the test.
Replaced with a real round-trip through Spring's Binder against an empty property source —
that actually exercises @DefaultValue resolution.

P0-2 — runner_post_turn_gc / runner_prewarm_ok / runner_prewarm_failed events were
write-only telemetry. The runner emitted them on every turn + every cold start; Java's
translator allow-listed them and dropped them; no consumer read them. They were added to
counter wave-24's "no observability" criticism but never wired through. Pure stdout noise.
Cut entirely. If we want production observability for GC/prewarm, that's a separate,
deliberate commit (wired to MeterRegistry, with a real consumer). Side effect: handleHello
re-entrance pollution disappears (no more bogus runner_prewarm_ok durationMs=0 on reattach).

P0-3 — handleHello idempotency: solved by P0-2 (no events emitted → nothing to pollute).

P1 — global.gc() fired on EVERY agent_end, including 1-token turns. STW major GC costs
50-200 ms on a 100 MB heap (Node 22, nodejs/node#43378+); for a "Reply: ready." turn that
allocated 100 KB the cost is all pause, no benefit. Gated on
process.memoryUsage().heapUsed >= 64 MB so the call only fires when there's genuinely
something to compact.

P1 — Marginal-RSS gate: switched from Math.abs() to Math.max(0, signed). Wave 25 introduced
abs() with the rationale "bloat AND release both trigger investigation"; loop 3 caught the
flaw: a runner whose RSS happens to drop between floor and K-opens samples (V8 GC timing,
allocator decay) is not a regression. Only growth is. The signed-delta clamped at 0 asserts
the direction we care about and avoids false-positive flakes on a normal V8 scavenge.

P1 — Allocator self-check at runner startup. PiRuntimeFactory passes
LD_PRELOAD=/usr/local/lib/libjemalloc.so.2 and the Dockerfile creates the per-arch symlink
at build time. If either drifts (symlink missing on a future image, env clobbered by
deploy config) ld.so silently falls back to glibc and the wave-25 jemalloc tuning silently
disappears. Now reads /proc/self/maps at startup and logs a single WARN line on glibc
fallback. Currently fires correctly on the host stress harness (no Docker → no LD_PRELOAD);
silent in production unless drift happens.

Translator allowlist + test entries for the dropped event types removed in lockstep.

Validated: PiRuntimeFactoryTest 29 + PiEventToUiChunkTranslatorTest 33 + all mentor unit
tests green. Live stress N=3 (cold-start 64 ms, peak RSS 165-170 MB) + N=3×K=5 (peak RSS
169-172 MB) — 0 failures, all budgets satisfied.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

+1 more reviewer

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @bnb @VoltrexKeyva @LiviaMedeiros