lib,tools: rename functions named value

[LiviaMedeiros]

Refs: #57899

This PR adds a node-core/func-name-matching linter rule that correctly handles defining properties with functions as value, and fixes the function names accordingly.

Authored by @louiellan

[nodejs-github-bot]

Review requested:

• @nodejs/startup
• @nodejs/streams
• @nodejs/test_runner
• @nodejs/web-standards

[ljharb]

it'd be great to get a PR that just fixes the value-named functions and disables the lint rule so that it can be released and maximally backported.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (4ee7567) to head (55163d9).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57901      +/-   ##
==========================================
+ Coverage   90.05%   90.07%   +0.02%     
==========================================
  Files         714      714              
  Lines      225876   225956      +80     
  Branches    42737    42739       +2     
==========================================
+ Hits       203408   203541     +133     
+ Misses      14244    14202      -42     
+ Partials     8224     8213      -11     

Files with missing lines	Coverage Δ
lib/fs.js	98.19% <100.00%> (ø)
...internal/bootstrap/web/exposed-window-or-worker.js	93.79% <100.00%> (ø)
lib/internal/console/constructor.js	98.19% <100.00%> (+<0.01%)	⬆️
lib/internal/modules/esm/hooks.js	86.05% <100.00%> (ø)
lib/internal/modules/esm/translators.js	97.51% <100.00%> (ø)
lib/internal/per_context/domexception.js	96.62% <100.00%> (ø)
lib/internal/streams/writable.js	96.39% <100.00%> (-0.25%)	⬇️
lib/internal/util/types.js	100.00% <100.00%> (ø)
lib/internal/worker/io.js	99.19% <100.00%> (ø)
lib/zlib.js	98.30% <100.00%> (+<0.01%)	⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[louiellan]

Hello, I've worked on the eslint rule for this one, i've just made some changes with the eslint's func-name-matching rule, and its ruletester.

You can check the work here: lib-name-functions

Let me know if you guys have any thoughts on this :>, and if all is good, i could send a PR to this PR's branch.

[LiviaMedeiros]

@louiellan sorry for the late response. Yes, the code in your branch LGTM! Small adjustments: - the test's filename should start with `test-`, i.e. `func-name-matching.test.js` should be renamed to something like `test-eslint-func-name-matching.js`. - i think the `@author` comments should be in separate lines (with multiple `@author` tags) rather than comma-separated. Please feel free to open a PR either against this branch, or directly against main branch (not preserving my commit is also okay). Or i can merge your commits into this PR once am on PC (probably mid-August). Thank you!

[louiellan]

@LiviaMedeiros I've made the adjustments and here's the pull request to your branch, LiviaMedeiros#1

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68346/

[louiellan]

Hello, feel free to ping me if this needs to be merged, this might be blocked because of the Signed-off-by requirement

[LiviaMedeiros]

@louiellan apologies for late response and thank you!
To be honest, right now i'm not completely sure that this is the best way to move forward with these value() functions, as the issue is not really Node.js-specific. Should we consider submitting this rule to eslint itself so it's accessible by default? Of course in case if for some reason it gets rejected there, we can keep it as node-core/ option.

[louiellan]

Now that you mentioned it, I realized that i only handled the explicit naming but not the concise notation functions (I'll work on it)

but we still need to have a separate node-core version here fixing also the same thing 'cause of primordials

as per submitting the rule to eslint, we'll need to make non-nodejs one (will work on it as well, I'll just mention you there and reference also the issue you made)

[mcollina]

lgtm

[Ethan-Arrowood]

nice improvement