Skip to content

tools: update the llhttp updater script#63819

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:llhttp-updater
Jun 19, 2026
Merged

tools: update the llhttp updater script#63819
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:llhttp-updater

Conversation

@aduh95

@aduh95 aduh95 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Simplifies the script by dropping the git commands and consolidate around a single code path whether we're dealing with an existing local clone or a fresh tarball extract. Also removed the dependency on the global npm, disable running scripts, and switched to npm ci instead of npm install

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 9, 2026
@aduh95 aduh95 requested a review from ShogunPanda June 9, 2026 18:13
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2026
@nodejs-github-bot nodejs-github-bot merged commit a4f9858 into nodejs:main Jun 19, 2026
21 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a4f9858

@aduh95 aduh95 deleted the llhttp-updater branch June 19, 2026 09:35
aduh95 added a commit that referenced this pull request Jun 20, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63819
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants