Repository navigation
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Collaborator
|
Review requested:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at windows failures one test showed as a reasonably regular intermittent failure specifically on win32. Since we already have some marked as flaky it seems reasonable to include this one too.
The earliest log that's still around where I can see it is from the PR test run of an undici update: where the PR test was re-run and succeeded.
When it fails the retry logic shows varying results between 1/10 failures and 7/10:
Sample failure output:
Interestingly in this case it's showing the exception being thrown at line 53 which would suggest it didn't go into the
if (common.isWindows)block to trigger thesigntoolskip message that happens in the case where it doesn't "fail".I haven't analysed this in any more detail as it's an experimental feature on a platform that will disappear when Node 22x goes out of support next year so I feel that just marking it flaky is the right option unless @joyeecheung is particularly interested in trying to make it work differently :-)
Spotted while looking at intermittent failures on Windows that weren't being picked up by the reliability reports.
Draft for now while I look at running a few more experiments in the background.