Skip to content

Move from tap to the node core test runner #2267

Closed

Description

@mcollina

As titled

This could be part of the next semver major that drops old nodes.

Activity

  1. ashutoshdhande commented on Dec 27, 2023

    @ashutoshdhande

    Will give a shot at this

  2. anurag-roy commented on Dec 27, 2023

    @anurag-roy
    Contributor

    @mcollina There are a lot of test files using tap (around 150).

    Are we looking to migrate all of them in one PR or migrating part by part is fine?

  3. pmarchini commented on Dec 27, 2023

    @pmarchini
    Member

    Hey!

    Given the large number of tests and the need to meticulously avoid false positives, would it be more effective to split the test suites into separate PRs?

    For instance, test:cookies appears to be easily portable independently of other suites.

    How about we create a list of these suites to distribute the workload and more effectively monitor the outcomes?

  4. Uzlopak commented on Jan 27, 2024

    @Uzlopak
    Contributor

    Is there something like t.plan in node:test?

  5. anurag-roy commented on Jan 27, 2024

    @anurag-roy
    Contributor

    @Uzlopak There isn't, we are using @matteo.collina/tspl package instead of t.plan

    Example usage here.

  6. Uzlopak commented on Feb 8, 2024

    @Uzlopak
    Contributor

    I am on this now.

    I opened a PR #2719 for an example transformation.
    Also I will split the necessary work into smaller PRs to reduce the review work.

  7. Uzlopak commented on Feb 9, 2024

    @Uzlopak
    Contributor

    Opened #2720 and #2721 to incrementally prepare the following PR.

  8. Uzlopak commented on Feb 12, 2024

    @Uzlopak
    Contributor

    LOL. I created basically 6 batches and lost the following stuff, which I stashed in git.

    So please review and merge the open PRs. Then I can continue to migrate it.

  9. Uzlopak commented on Feb 13, 2024

    @Uzlopak
    Contributor

    Nice. Its done.

    Maybe we can do the same in fastify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions