You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given the large number of tests and the need to meticulously avoid false positives, would it be more effective to split the test suites into separate PRs?
For instance, test:cookies appears to be easily portable independently of other suites.
How about we create a list of these suites to distribute the workload and more effectively monitor the outcomes?
Reacted by Anurag Roy, Carlos Fuentes and Matteo Collina
Activity
ashutoshdhande commentedon Dec 27, 2023
Will give a shot at this
anurag-roy commentedon Dec 27, 2023
@mcollina There are a lot of test files using
tap(around 150).Are we looking to migrate all of them in one PR or migrating part by part is fine?
pmarchini commentedon Dec 27, 2023
Hey!
Given the large number of tests and the need to meticulously avoid false positives, would it be more effective to split the test suites into separate PRs?
For instance,
test:cookiesappears to be easily portable independently of other suites.How about we create a list of these suites to distribute the workload and more effectively monitor the outcomes?
Uzlopak commentedon Jan 27, 2024
Is there something like t.plan in node:test?
anurag-roy commentedon Jan 27, 2024
@Uzlopak There isn't, we are using
@matteo.collina/tsplpackage instead of t.planExample usage here.
Uzlopak commentedon Feb 8, 2024
I am on this now.
I opened a PR #2719 for an example transformation.
Also I will split the necessary work into smaller PRs to reduce the review work.
Uzlopak commentedon Feb 9, 2024
Opened #2720 and #2721 to incrementally prepare the following PR.
Uzlopak commentedon Feb 12, 2024
LOL. I created basically 6 batches and lost the following stuff, which I stashed in git.
So please review and merge the open PRs. Then I can continue to migrate it.
Uzlopak commentedon Feb 13, 2024
Nice. Its done.
Maybe we can do the same in fastify